Traverse upwards for single context projects #7896
Open
+158
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR implements upward directory traversal for package resolution in single context projects, allowing ReScript to find dependencies in parent node_modules directories when building standalone packages in workspace setups.
Key changes include:
- Added upward traversal logic that searches parent directories for node_modules when dependencies aren't found locally
- Implemented caching mechanism to optimize repeated path existence checks during traversal
- Added comprehensive test coverage for standalone package builds
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rewatch/src/helpers.rs | Core implementation of upward traversal logic with caching for package resolution |
| rewatch/tests/compile.sh | Added test case for standalone package building via rescript command |
| rewatch/testrepo/packages/standalone/* | Test fixtures for standalone package with dependency on @testrepo/dep01 |
| rewatch/testrepo/package.json | Added standalone package to workspace and updated scripts to use rescript instead of rewatch |
| CHANGELOG.md | Documented the new upward traversal feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the upwards traversal as discussed in #7117 (comment)