Fix required star #990
Merged
Fix required star #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🪓 PR closed, deleted preview. |
This was
linked to
issues
Dec 18, 2025
JackWilb
approved these changes
Jan 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes the positioning of the required asterisk (*) in markdown prompts by improving the algorithm that locates where to insert the asterisk. Previously, the asterisk would appear in unexpected positions when markdown formatting was used in question prompts. The fix ensures the asterisk always appears at the end of the actual text content.
Key Changes:
- Updated the algorithm to first find the last non-empty text node, then locate its parent Element, instead of simply finding the last Element
- Added logic to determine when a space is needed before the last word when inserting the asterisk
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #900
Closes #972
Give a longer description of what this PR addresses and why it's needed
Fix required star appears in unexpected place when using markdown in the question prompt
Provide pictures/videos of the behavior before and after these changes (optional)
After
Before
Are there any additional TODOs before this PR is ready to go?
TODOs:
No