voice chats v2 #414
Open
voice chats v2 #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix up code undo changes to compose file add back .env.example
feat: call started system message in dms
IAmTomahawkx
requested changes
Aug 3, 2025
| } | ||
|
|
||
| if revision <= 42 { | ||
| info!("Running migration [revision 33 / 29-04-2025]: Convert all `VoiceChannel`'s into `TextChannel` "); |
There was a problem hiding this comment.
Suggested change
| info!("Running migration [revision 33 / 29-04-2025]: Convert all `VoiceChannel`'s into `TextChannel` "); | |
| info!("Running migration [revision 42 / 29-04-2025]: Convert all `VoiceChannel`'s into `TextChannel` "); |
There was a problem hiding this comment.
This'll all need to be confirmed prior to final merging anyways.
| voice.replace(v); | ||
| } | ||
| }, | ||
| Self::VoiceChannel { .. } => {} |
There was a problem hiding this comment.
panic or error here since a migration should remove all of these?
| @@ -32,6 +39,7 @@ pub async fn edit( | |||
|
|
|||
| // Fetch server and member | |||
| let mut server = server.as_server(db).await?; | |||
| let target_user = member.as_user(&db).await?; | |||
There was a problem hiding this comment.
Suggested change
| let target_user = member.as_user(&db).await?; | |
| let target_user = member.as_user(db).await?; |
github-project-automation
bot
moved this from 🆕 Untriaged
to 🛑 Changes requested
in Pull Request Overview
- move voice and video limits to config - seperate VoiceInformation into model and db model - fix build scripts
check max participants when creating a token to avoid giving tokens but erroring when attempting to join, check if the channel actually supports voice
fix: calculate user overwrites correctly fix: dont include personal info in livekit user metadata fix: revoke video permissons on denied publish fix: add video to default permissions
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #318
Porting voice services to livekit.
Tracking issue: #313