Skip to content

Conversation

@clcollins
Copy link

Summary

Fixes Make parsing error when GOPATH contains multiple colon-separated paths (common with gvm pkgsets).

The Makefile now extracts only the first component of GOPATH, which:

  • Avoids Make interpreting colons as pattern rule delimiters
  • Points to the correct location where go install puts binaries
  • Works with both single-path and multi-path GOPATH configurations

Test plan

  • Verified make build works with multi-path GOPATH
  • Verified make lint target parses correctly
  • Tested with single-path GOPATH (still works)

🤖 Generated with Claude Code

Extract first component of GOPATH to avoid Make interpreting colons
as pattern rule delimiters when using gvm pkgsets or other multi-path
GOPATH configurations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2025
@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.63%. Comparing base (84bd137) to head (d7e3dcf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files           6        6           
  Lines         736      736           
=======================================
  Hits          461      461           
  Misses        233      233           
  Partials       42       42           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant