-
Notifications
You must be signed in to change notification settings - Fork 32
Lawrencemm conan #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 15 15
=====================================
Hits 15 15 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 15 15
=====================================
Hits 15 15 Continue to review full report at Codecov.
|
@Lawrencemm I just pushed some tweaks to the conan recipe, do they look alright to you? I separated them into multiple commits so that intention behind each change is clear from the commit message. The output of
Any idea how to remove them? |
I think a good idea would be to get this package reviewed before merging the PR by someone from conan-center. Do you have a bintray account? If you upload the package you can go here: https://bintray.com/beta/#/conan/conan-center?tab=packages And click "Actions" then "Include my package". Select the package you uploaded and in the "Additional Comments" add a link to this PR. They should tell us whether these warnings are anything to worry about and anything else we need to do to get the package included. |
Retry #6 after CI fixing.