Skip to content

Conversation

ricab
Copy link
Owner

@ricab ricab commented May 1, 2019

Retry #6 after CI fixing.

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760de0a...4bbdd96. Read the comment docs.

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760de0a...efe5708. Read the comment docs.

@ricab
Copy link
Owner Author

ricab commented May 1, 2019

@Lawrencemm I just pushed some tweaks to the conan recipe, do they look alright to you? I separated them into multiple commits so that intention behind each change is clear from the commit message.

The output of conan create . demo/testing had the following warnings:

[...]
scope_guard/0.2.4-dev.1@demo/testing: WARN: Forced build from source
[...]
scope_guard/0.2.4-dev.1@demo/testing: WARN: This conanfile has no build step
[...]
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
[...]

Any idea how to remove them?

@Lawrencemm
Copy link

I think a good idea would be to get this package reviewed before merging the PR by someone from conan-center.

Do you have a bintray account?

If you upload the package you can go here: https://bintray.com/beta/#/conan/conan-center?tab=packages

And click "Actions" then "Include my package".

Select the package you uploaded and in the "Additional Comments" add a link to this PR. They should tell us whether these warnings are anything to worry about and anything else we need to do to get the package included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants