Skip to content

Conversation

7908837174
Copy link
Contributor

@7908837174 7908837174 commented Aug 30, 2025

I have successfully created a clean branch add-zvfofp8min-extension-clean with only the necessary Zvfofp8min extension file added, addressing the maintainer's concern about extra changes in PR #1030, and pushed it to the repository.

Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (b5d25b9) to head (1c21e52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          11       11           
  Lines        4942     4942           
  Branches     1345     1345           
=======================================
  Hits         2276     2276           
  Misses       2666     2666           
Flag Coverage Δ
idlc 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +11 to +16
This extension provides the minimal set of instructions needed to enable vector support of the
OFP8 format.
It enables OFP8 as an interchange format as it provides conversion between OFP8 values and FP32 values.
The extension offers conversion between OFP8 and BF16 (both directions), and from FP32 to OFP8
(only quad narrowing conversion). The narrowing conversions support both saturate and non-saturate
modes. Both OFP8 formats, E4M3 and E5M2, are supported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this text originate? It would be best to use text directly from the spec.

type: unprivileged
versions:
- version: "0.2.1"
state: ratified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: ratified
state: development

Comment on lines +24 to +27
requires:
anyOf:
- V
- Zve32f No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my understanding:

Suggested change
requires:
anyOf:
- V
- Zve32f
requires: Zve32f

The "Zve*" extensions are designed for minimal vector support in embedded-class implementations, not full "V"/RVV support.

@ThinkOpenly
Copy link
Collaborator

Does this supercede #1030? If so, could you close that PR, please?

@ThinkOpenly
Copy link
Collaborator

The CI regress-pre-commit test is failing due to an end-of-file issue:

--- a/spec/std/isa/ext/Zvfofp8min.yaml
+++ b/spec/std/isa/ext/Zvfofp8min.yaml
@@ -24,4 +24,4 @@ versions:
     requires:
       anyOf:
         - V
-        - Zve32f
\ No newline at end of file
+        - Zve32f

Could you push a commit which fixes that?

@ThinkOpenly
Copy link
Collaborator

What are the status and expectations here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants