-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add zvfofp8min extension #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add zvfofp8min extension #1049
Conversation
Signed-off-by: 7908837174 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This extension provides the minimal set of instructions needed to enable vector support of the | ||
OFP8 format. | ||
It enables OFP8 as an interchange format as it provides conversion between OFP8 values and FP32 values. | ||
The extension offers conversion between OFP8 and BF16 (both directions), and from FP32 to OFP8 | ||
(only quad narrowing conversion). The narrowing conversions support both saturate and non-saturate | ||
modes. Both OFP8 formats, E4M3 and E5M2, are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this text originate? It would be best to use text directly from the spec.
type: unprivileged | ||
versions: | ||
- version: "0.2.1" | ||
state: ratified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state: ratified | |
state: development |
requires: | ||
anyOf: | ||
- V | ||
- Zve32f No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my understanding:
requires: | |
anyOf: | |
- V | |
- Zve32f | |
requires: Zve32f |
The "Zve*" extensions are designed for minimal vector support in embedded-class implementations, not full "V"/RVV support.
Does this supercede #1030? If so, could you close that PR, please? |
The CI regress-pre-commit test is failing due to an end-of-file issue:
Could you push a commit which fixes that? |
What are the status and expectations here? |
I have successfully created a clean branch add-zvfofp8min-extension-clean with only the necessary Zvfofp8min extension file added, addressing the maintainer's concern about extra changes in PR #1030, and pushed it to the repository.