fix: improve CI robustness and code cleanup #1091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
7908837174
commented
Sep 18, 2025
7908837174
commented
- Remove duplicate directory creation
- Remove deprecated bundle flags
- Cleanup CI workflows
- Add specification_source to extensions
- Fix schema and YAML files
- Remove duplicate directory creation - Remove deprecated bundle flags - Cleanup CI workflows - Add specification_source to extensions - Fix schema and YAML files Co-authored-by: 7908837174 <[email protected]>
- Added Ruby environment setup using ruby/setup-ruby@v1 - Configured bundler to use vendor/bundle path - Added proper dependency installation steps - Fixed CI failures related to Ruby gems
ThinkOpenly
reviewed
Sep 18, 2025
Comment on lines
19
to
23
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.2' | ||
| bundler-cache: true |
ThinkOpenly
reviewed
Sep 18, 2025
bin/build_container
Outdated
Comment on lines
71
to
73
| if [ -e ${CONTAINER_PATH} ]; then | ||
| rm -f ${CONTAINER_PATH} | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [ -e ${CONTAINER_PATH} ]; then | |
| rm -f ${CONTAINER_PATH} | |
| fi | |
| rm -f ${CONTAINER_PATH} |
Might as well collapse this, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.