-
Notifications
You must be signed in to change notification settings - Fork 114
feat(examples): multitenant using remote builds #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
abcxff
wants to merge
1
commit into
06-16-fix_toolchain_creating_ci_env_no_longer_fails_first_try
from
06-16-feat_examples_multitenant_using_remote_builds
Closed
feat(examples): multitenant using remote builds #2619
abcxff
wants to merge
1
commit into
06-16-fix_toolchain_creating_ci_env_no_longer_fails_first_try
from
06-16-feat_examples_multitenant_using_remote_builds
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updates multitenant-deploys example to use remote builds instead of local builds, with significant architectural changes in deployment workflow.
- Security Issue: Hardcoded sensitive cloud token and project IDs exposed in
examples/multitenant-deploys/README.md
- Infrastructure Change: Switched from
get.rivet.gg
toreleases.rivet.gg
for CLI installation inexamples/multitenant-deploys/Dockerfile
- Architecture Update: Removed
@rivet-gg/api-full
workspace dependency in favor of remote builds inpackage.json
- Configuration Change: Added unstable.build_method config and modified dockerfile paths in
src/app.ts
4 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
NathanFlurry
requested changes
Jun 18, 2025
d9ac5ae
to
72b8887
Compare
72b8887
to
00e503a
Compare
00e503a
to
17ff3d9
Compare
NathanFlurry
approved these changes
Jun 20, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. --> Fixes RVT-4791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes RVT-4791