Skip to content

Conversation

abcxff
Copy link
Contributor

@abcxff abcxff commented Jun 16, 2025

Changes

Fixes RVT-4791

Copy link

linear bot commented Jun 16, 2025

Copy link
Contributor Author

abcxff commented Jun 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@abcxff abcxff requested a review from NathanFlurry June 16, 2025 19:17
@abcxff abcxff marked this pull request as ready for review June 16, 2025 19:18
Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 17ff3d9
Status:🚫  Build failed.

View logs

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates multitenant-deploys example to use remote builds instead of local builds, with significant architectural changes in deployment workflow.

  • Security Issue: Hardcoded sensitive cloud token and project IDs exposed in examples/multitenant-deploys/README.md
  • Infrastructure Change: Switched from get.rivet.gg to releases.rivet.gg for CLI installation in examples/multitenant-deploys/Dockerfile
  • Architecture Update: Removed @rivet-gg/api-full workspace dependency in favor of remote builds in package.json
  • Configuration Change: Added unstable.build_method config and modified dockerfile paths in src/app.ts

4 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

@abcxff abcxff force-pushed the 06-16-feat_examples_multitenant_using_remote_builds branch from d9ac5ae to 72b8887 Compare June 18, 2025 16:37
@abcxff abcxff requested a review from NathanFlurry June 18, 2025 16:39
@abcxff abcxff force-pushed the 06-16-feat_examples_multitenant_using_remote_builds branch from 72b8887 to 00e503a Compare June 18, 2025 16:41
@abcxff abcxff force-pushed the 06-16-feat_examples_multitenant_using_remote_builds branch from 00e503a to 17ff3d9 Compare June 18, 2025 16:53
Copy link
Contributor

graphite-app bot commented Jun 20, 2025

Merge activity

  • Jun 20, 7:23 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 20, 7:24 PM UTC: CI is running for this pull request on a draft pull request (#2631) due to your merge queue CI optimization settings.
  • Jun 20, 7:24 PM UTC: Merged by the Graphite merge queue via draft PR: #2631.

graphite-app bot pushed a commit that referenced this pull request Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
Fixes RVT-4791
@graphite-app graphite-app bot closed this Jun 20, 2025
@graphite-app graphite-app bot deleted the 06-16-feat_examples_multitenant_using_remote_builds branch June 20, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants