- 
                Notifications
    You must be signed in to change notification settings 
- Fork 130
chore(pegboard): add exit code log from container runner #2477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pegboard): add exit code log from container runner #2477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added exit code logging functionality to the container runner to improve observability of container termination states.
- Added logging to packages/edge/infra/client/container-runner/src/main.rsthat captures container exit codes and sends them to stderr and the log shipper
- Added message formatting for both successful exits (Exited with exit code {exit_code}) and failures (Aborting)
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| container::send_message( | ||
| &msg_tx, | ||
| None, | ||
| log_shipper::StreamType::StdErr, | ||
| format!("Exited with exit code {exit_code}"), | ||
| ); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using stdout instead of stderr for successful exit codes since this is expected behavior, not an error condition
| Deploying rivet-hub with   | 
| Latest commit: | f387ef2 | 
| Status: | ✅ Deploy successful! | 
| Preview URL: | https://1ae84aa9.rivet-hub-7jb.pages.dev | 
| Branch Preview URL: | https://05-27-chore-pegboard-add-exi.rivet-hub-7jb.pages.dev | 
85b69de    to
    81cf3fb      
    Compare
  
    2c5c2c3    to
    469ba5f      
    Compare
  
    2dd8abc    to
    dfaf6f7      
    Compare
  
    f20b30f    to
    03f6f81      
    Compare
  
    | Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
dfaf6f7    to
    f31f5b8      
    Compare
  
    03f6f81    to
    c6943e6      
    Compare
  
    | Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the  You can disable this status message by setting the  Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit: 
 SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
 Other keywords and placeholders
 CodeRabbit Configuration File ( | 
| Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
| Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
c6943e6    to
    d651a8c      
    Compare
  
    | Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
a30bfaf    to
    983d5fc      
    Compare
  
    d651a8c    to
    017878a      
    Compare
  
    | Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
017878a    to
    d6072b5      
    Compare
  
    | The latest updates on your projects. Learn more about Vercel for GitHub. 
 | 
| Claude finished @MasterPtato's task —— View job Code Review Complete ✅I've reviewed this PR for code quality, potential bugs, performance, security concerns, and test coverage. Todo List:
 Review Feedback✅ Code Quality & Best Practices
 
 | 
d6072b5    to
    f387ef2      
    Compare
  
    | Claude encountered an error —— View job I'll analyze this and get back to you. | 


Changes