Skip to content

chore: disable OTEL by default in guard service #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: disable OTEL by default in guard service #2522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...vices/cluster/src/workflows/server/install/install_scripts/files/rivet_guard_configure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ After=network-online.target
ConditionPathExists=/etc/rivet-server/

[Service]
Environment="RIVET_OTEL_ENABLED=1"
# OTEL is not enabled by default since it eats memory very quickly
Environment="RIVET_OTEL_SAMPLER_RATIO=1"
Comment on lines +18 to 19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: RIVET_OTEL_SAMPLER_RATIO=1 has no effect if OTEL is disabled. Consider removing this line entirely to avoid confusion.

Environment="RIVET_SERVICE_NAME=guard"
Environment="RIVET_NAMESPACE=__NAMESPACE__"
Expand Down
Loading