fix(pegboard): wait for actor allocation not creation #2539

MasterPtato · 2025-06-04T19:08:15Z

Changes

MasterPtato · 2025-06-04T19:08:57Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

Modifies actor lifecycle management to wait for allocation instead of creation, improving reliability and state tracking.

Changed actors.rs to wait for Allocated signal instead of CreateComplete before proceeding
Added new Allocated message type in mod.rs with client_id for better lifecycle tracking
Implemented allocation check before entering main state loop in actor workflow
Ensures proper actor resource allocation before continuing with other operations

_{2 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-04T19:08:59Z

packages/edge/services/pegboard/src/workflows/actor/mod.rs

+	ctx.msg(Allocated {
+		client_id: res.client_id,
+	})
+	.tag("actor_id", input.actor_id)
+	.send()
+	.await?;


logic: Sending Allocated message before state loop could lead to false positives if actor fails to initialize in state loop

cloudflare-workers-and-pages · 2025-06-04T19:11:18Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`d6aaade`
Status:	✅ Deploy successful!
Preview URL:	https://48cf04dc.rivet-studio.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-wait-for.rivet-studio.pages.dev

View logs

cloudflare-workers-and-pages · 2025-06-04T19:11:41Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`d6aaade`
Status:	✅ Deploy successful!
Preview URL:	https://fc47a2d3.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-wait-for.rivet-hub-7jb.pages.dev

View logs

cloudflare-workers-and-pages · 2025-06-04T19:11:43Z

Deploying rivet with Cloudflare Pages

Latest commit:	`d6aaade`
Status:	✅ Deploy successful!
Preview URL:	https://18db9cc4.rivet.pages.dev
Branch Preview URL:	https://06-04-fix-pegboard-wait-for.rivet.pages.dev

View logs

graphite-app · 2025-06-09T16:46:59Z

Merge activity

Jun 9, 4:46 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

## Changes

MasterPtato requested a review from NathanFlurry June 4, 2025 19:08

MasterPtato mentioned this pull request Jun 4, 2025

Fix(guard): return error response on router error #2540

Closed

greptile-apps bot reviewed Jun 4, 2025

View reviewed changes

MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 4f69969 to a38c8f3 Compare June 4, 2025 19:17

MasterPtato force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from c0249ae to 60de115 Compare June 4, 2025 19:17

This was referenced Jun 4, 2025

feat(clusters): add margin per pool #2543

Closed

fix(pegboard): increase actor log ttl to 14 days #2544

Closed

chore(vector): add vector pipeline to ship clickhouse events from the edge #2526

Closed

NathanFlurry force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 60de115 to 779cf53 Compare June 5, 2025 00:58

NathanFlurry force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from a38c8f3 to 100bf59 Compare June 5, 2025 00:58

MasterPtato force-pushed the 06-04-fix_pegboard_increase_signal_timeout_add_check_for_actor_exit branch from 100bf59 to 5517494 Compare June 5, 2025 02:10

MasterPtato force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 779cf53 to 5526790 Compare June 5, 2025 02:10

This was referenced Jun 5, 2025

chore: fix dc wf #2552

Closed

fix: add vector http config to edge configs #2553

Closed

MasterPtato force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 5526790 to 6d98c23 Compare June 6, 2025 01:36

fix(pegboard): wait for actor allocation not creation

d6aaade

MasterPtato force-pushed the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch from 6d98c23 to d6aaade Compare June 6, 2025 18:29

This was referenced Jun 6, 2025

fix(pegboard): fix allocation metrics #2568

Closed

fix: dont include installing servers in service discovery #2569

Closed

feat: db sh for workflows #2570

Closed

graphite-app bot closed this Jun 9, 2025

graphite-app bot deleted the 06-04-fix_pegboard_wait_for_actor_allocation_not_creation branch June 9, 2025 16:49

github-actions bot mentioned this pull request Jun 9, 2025

chore(main): release 25.5.1 #2423

Merged

MasterPtato mentioned this pull request Jun 9, 2025

fix(pegboard): fix container runner orphaning #2575

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(pegboard): wait for actor allocation not creation #2539

fix(pegboard): wait for actor allocation not creation #2539

Uh oh!

MasterPtato commented Jun 4, 2025

Uh oh!

MasterPtato commented Jun 4, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jun 4, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

fix(pegboard): wait for actor allocation not creation #2539

fix(pegboard): wait for actor allocation not creation #2539

Uh oh!

Conversation

MasterPtato commented Jun 4, 2025

Changes

Uh oh!

MasterPtato commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

graphite-app bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MasterPtato commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 4, 2025 •

edited

Loading

graphite-app bot commented Jun 9, 2025 •

edited

Loading