Skip to content

fix(pegboard): fix container runner orphaning #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(pegboard): fix container runner orphaning #2575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/edge/infra/client/container-runner/src/container.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ pub fn run(
actor_id,
fs_path.display()
);

let mut runc_child = Command::new("runc")
.arg("run")
.arg(&actor_id)
Expand Down
2 changes: 1 addition & 1 deletion packages/edge/infra/client/manager/src/actor/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ impl Actor {
match Command::new("runc")
.arg("delete")
.arg("--force")
.arg(self.actor_id.to_string())
.arg(format!("{}-{}", self.actor_id, self.generation))
.output()
Comment on lines 719 to 723
Copy link

@greptile-apps greptile-apps bot Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Ensures correct container instance is deleted when multiple generations exist, preventing orphaned containers

.await
{
Expand Down
Loading