feat(pegboard): outbound runners #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 5, 2025
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
NathanFlurry
changed the base branch from
09-03-chore_runner_add_ability_to_disable_auto-shutdown
to
graphite-base/2873
MasterPtato
force-pushed
the
09-05-feat_pegboard_outbound_runners
branch
from
91aa71d to
a6c2ba1
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
changed the base branch from
graphite-base/2873
to
09-03-chore_runner_add_ability_to_disable_auto-shutdown
MasterPtato
force-pushed
the
09-05-feat_pegboard_outbound_runners
branch
from
a6c2ba1 to
efb896e
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
328
to
333
| let namespace_id = state.namespace_id; | ||
| let runner_id = state.runner_id; | ||
| let ns_runner_kind = &state.ns_runner_kind; | ||
|
|
||
| ctx.udb()? | ||
| .run(|tx, _mc| async move { |
There was a problem hiding this comment.
The destroy::clear_slot() function signature has been updated to include a ns_runner_kind parameter, but this call site is missing that parameter. The function should be called with ns_runner_kind as the fourth argument:
destroy::clear_slot(
input.actor_id,
namespace_id,
runner_name_selector,
runner_id,
ns_runner_kind, // This parameter is missing
&tx,
)Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
NathanFlurry
changed the base branch from
09-03-chore_runner_add_ability_to_disable_auto-shutdown
to
graphite-base/2873
This was referenced Sep 6, 2025
MasterPtato
force-pushed
the
graphite-base/2873
branch
from
8bdf226 to
fe6d7a9
Compare
MasterPtato
force-pushed
the
09-05-feat_pegboard_outbound_runners
branch
from
efb896e to
fc97845
Compare
jog1t
force-pushed
the
09-11-fix_engine_fe_remove_addresses
branch
from
78771e3 to
f3087f3
Compare
jog1t
force-pushed
the
09-05-feat_pegboard_outbound_runners
branch
from
e328b2d to
57c4d39
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
…en disconnected/reconnecting
MasterPtato
force-pushed
the
09-11-fix_engine_fe_remove_addresses
branch
from
f3087f3 to
9549b26
Compare
MasterPtato
force-pushed
the
09-05-feat_pegboard_outbound_runners
branch
from
57c4d39 to
5ddcc85
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Merged
Base automatically changed from
09-11-fix_engine_fe_remove_addresses
to
main
September 16, 2025 08:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.