-
Notifications
You must be signed in to change notification settings - Fork 44
chore(core): allow configuring metadata #1406
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Allow configuring metadataSummaryThis PR adds support for configuring metadata in serverless runner configurations. The change allows platforms to identify themselves via metadata (e.g., Issues Found🔴 Critical: Type Definition MismatchThe Current interface: export interface RunnerConfigRequest {
datacenters: Record<
string,
{
serverless: {
url: string;
headers: Record<string, string>;
max_runners: number;
min_runners: number;
request_lifespan: number;
runners_margin: number;
slots_per_runner: number;
};
}
>;
} Required fix: export interface RunnerConfigRequest {
datacenters: Record<
string,
{
serverless: {
url: string;
headers: Record<string, string>;
max_runners: number;
min_runners: number;
request_lifespan: number;
runners_margin: number;
slots_per_runner: number;
};
metadata: Record<string, unknown>;
}
>;
} This will cause TypeScript compilation errors when running Recommendations
Positive Notes
SeverityHigh - The missing type definition will cause compilation errors and runtime type mismatches. |
More templates
@rivetkit/actor
@rivetkit/cloudflare-workers
@rivetkit/core
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
commit: |
Merge activity
|
No description provided.