Skip to content

Add new tactic "ensatz" for proving polynomial equalities with existential quantifier #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new tactic "ensatz" for proving polynomial equalities with existential quantifier #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e4460e
Add new tactic "ensatz" for proving polynomial equalities with existe…
lyonel2017 Apr 23, 2025
f51dbb6
Add support for existential variable to "ensatz"
lyonel2017 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions doc/changelog/02-added/160-feature-ensatz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
- in `ENsatzTactic`

+ Add new tactic `ensatz` for proving polynomial equalities
with existential quantifiers or existential variables
(`#160 <https://github.com/coq/stdlib/pull/160>`_,
by Lionel Blatter).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check add the documentation and link to it here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the remark. Is the changelog entry incomplete in terms of references to the new tactic's documentation? If so, I don't know how to proceed, since the documentation page for nsatz is in the Rocq project and not Stdlib. I wrote documentation for ensatz in my fork of Rocq.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the broken sentence. Yes, I meant that it would be nice to have a documentation link in the changelog (and have it committed, somewhere). Example.

Where to actually put the documentation is indeed an interesting question. There are actually three plausible places: rocq refman, stdlib refman, and stdlib html+coqdoc documentation. And I'm not sure what the high-level plan is for documentation or ml-supported tactics in the rocq-stdlib split. But documenting next to nsatz (and making a linked PR) seems fine.

- Add documentation for new tactic `ensatz`
(`#20762 <https://github.com/rocq-prover/rocq/pull/20762>`_,
by Lionel Blatter).

- in `ENsatz`

+ Add tests for tactic `ensatz`
(`#160 <https://github.com/coq/stdlib/pull/160>`_,
by Lionel Blatter).

Loading
Loading