Skip to content

Conversation

Safintim
Copy link

Description of the change

What if, for some reason, the exception is not hashable?

I ran into this problem using the library https://github.com/ecederstrand/exchangelib
Here's my pr ecederstrand/exchangelib#1097

I don't know why the author decided to do that. Asked the author, haven't received an answer yet. Anyway, it seems to me that it's worth providing for such a possibility.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant