Fix: Body serialization should respect max_nesting_depth config #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add maxDepth parameter to Body constructor - Update Body::serialize() to use maxDepth when calling serializeForRollbar - Update DataBuilder to pass maxNestingDepth config to Body constructor - Add test to verify deep nesting is properly truncated This fixes memory exhaustion issues when logging errors with complex nested data structures (like Drupal form arrays) by respecting the configured max_nesting_depth limit during Body serialization. Previously, Body::serialize() always used unlimited depth (-1) via serializeForRollbarInternal(), ignoring the max_nesting_depth config. Fixes memory issues similar to those described in issue reports about Rollbar consuming excessive memory with deeply nested context data.
danielmorell
previously approved these changes
Sep 12, 2025
There was a problem hiding this comment.
This looks good. Thank you for the work on this @AronNovak!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
This fixes memory exhaustion issues when logging errors with complex nested data structures (like Drupal form arrays) by respecting the configured max_nesting_depth limit during Body serialization.
Previously, Body::serialize() always used unlimited depth (-1) via serializeForRollbarInternal(), ignoring the max_nesting_depth config.
Fixes memory issues similar to those described in issue reports about Rollbar consuming excessive memory with deeply nested context data.
Type of change
Checklists
Development
Code review