Export telemetry from ReplayMap #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltjones
force-pushed
the
waltjones/telemetry-export-from-replaymap
branch
from
f68ca86 to
a672269
Compare
matux
reviewed
Sep 10, 2025
Comment on lines
+54
to
+59
| Telemeter.prototype.exportTelemetrySpan = function (attributes = {}) { | ||
| if (this.telemetrySpan) { | ||
| this.telemetrySpan.end(attributes); | ||
| this.telemetrySpan = this.tracing.startSpan('rollbar-telemetry', {}); | ||
| } | ||
| }; |
There was a problem hiding this comment.
I'm not sure I understand the intention, what is this function exporting and where to? Or is this just reseting/restarting the telemetry span? Or does ending the telemetrySpan moves data somewhere else?
There was a problem hiding this comment.
span.end() always causes an export. That's part of the standard tracing behavior.
This method ensures the currently open span is ended and exported so that it can be included in the next payload, and opens a new span to continue capturing telemetry events.
There was a problem hiding this comment.
And no new span is gonna be opened if no current telemetry span exist.
matux
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Refactor to trigger telemetry export from ReplayMap.
Type of change
Checklists
Development