feat: implement Main page #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-app into feat/main-page
Shastel
requested changes
Aug 5, 2025
| "hooks": "@/hooks" | ||
| }, | ||
| "iconLibrary": "lucide" | ||
| } No newline at end of file |
|
|
||
| const LoginPage = () => { | ||
| const redirectToGitHub = () => { | ||
| const githubAuthUrl = "https://github.com/login/oauth/authorize"; |
| import styles from "./LoginPage.module.css"; | ||
| import Image from "next/image"; | ||
|
|
||
| const GITHUB_CLIENT_ID = "YOUR_GITHUB_CLIENT_ID"; |
| const redirectUri = encodeURIComponent( | ||
| "http://localhost:3000/auth/github/callback" | ||
| ); | ||
| const scope = "read:user user:email"; |
Member
There was a problem hiding this comment.
The scope should be configurable
| icon: ( | ||
| <ThumbsUp | ||
| color="blue" | ||
| size={16} |
Member
There was a problem hiding this comment.
(not critical)
I would prefer if we define the size of the icons as a const and then use in the list.
|
|
||
| const maxDonatorsShown = 21; | ||
|
|
||
| class FooterLayout extends React.Component<any, any> { |
| import { SocialNetworks } from "./SocialNetworks"; | ||
| import { Donation } from "./Donation"; | ||
|
|
||
| const maxDonatorsShown = 21; |
Member
There was a problem hiding this comment.
(not crirical)
It is common practice to use ALL_CAPS for the constants
| const githubIssuesUrl = 'https://github.com/rolling-scopes/rsschool-app/issues'; | ||
| const publicRoutes = [ | ||
| { | ||
| icon: <Files color="#52c41a" size={16} />, |
| newTab: boolean; | ||
| }; | ||
|
|
||
| class Menu extends React.Component<MenuProps> { |
Member
There was a problem hiding this comment.
should be a functinal compoenent
|
|
||
| const socialLinks = [ | ||
| { | ||
| icon: <GitHubOutlined size={24} />, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Description
Main PageHeaderandFootercomponentsfavicon🖼️ Screenshots
🔧 To Do (Next Steps):
Say Thank you (Discord >> #gratitude)pageHeroespage for supporters