Remove roottest/graphics #20393
Open
Remove roottest/graphics #20393
+0
−10,359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was first attempt to introduce SVG testing But now stressGraphics implements same functionality - so we do not need duplicate code here. Main disadvantage of approach in roottest/graphics was usage of zipped files. So any small change in the SVG leads to complete replace of large file in repository. In stressGraphics SVG file as is are stored and small change in several lines does not explode size of the repository.
dpiparo
approved these changes
Nov 12, 2025
Test Results 21 files 21 suites 3d 16h 50m 7s ⏱️ For more details on these failures, see this check. Results for commit e218b23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was first attempt to introduce SVG testing
But now stressGraphics implements same functionality - so we do not need duplicate code here.
Main disadvantage of approach in roottest/graphics was usage of zipped files. So any small change in the SVG leads to complete replace of large file in repository.
In stressGraphics SVG file as is are stored and small change in several lines does not explode size of the repository.