-
Notifications
You must be signed in to change notification settings - Fork 76
Add InterfacesNames and InterfacesValues messages #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt the names be more specific? Like interface_names and interface_values or something like this? And why using two messages? If you want to go in the direction of pal_statistics, why not just use the messages from there?
I thought of having new messages that are generic and fix different use cases at the same time. The idea of using 2 messages is to reduce the size of the message. As per @bmagyar suggestion, I think it is a good idea to go with 2 different publishers, one as a transient_local for names and another for the list of values Regarding pal_statistics messages, I didn't want to depend on pal_statistics messages per se, as they semantically do not fit the current use case. Moreover, we will have only 1 version and won't be using the version tag |
Following the strategy of removing generic message types from std_msgs, I'd avoid "generic" messages but be more descriptive here.
This is fine.
Ok. |
@christophfroehlich What you say is very valid. I understand it. I was about to make the change and unfortunately found this InterfaceValue.msg this doesn't allow me to rename the message. Any help with alternative naming? |
|
Maybe |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit, apart from that LGTM
This PR adds the StringArray and ValuesArray message needed for the generic state broadcaster or the interface state broadcaster