Skip to content

Conversation

@saikishor
Copy link
Member

This PR adds the StringArray and ValuesArray message needed for the generic state broadcaster or the interface state broadcaster

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt the names be more specific? Like interface_names and interface_values or something like this? And why using two messages? If you want to go in the direction of pal_statistics, why not just use the messages from there?

@saikishor
Copy link
Member Author

shouldnt the names be more specific? Like interface_names and interface_values or something like this? And why using two messages? If you want to go in the direction of pal_statistics, why not just use the messages from there?

I thought of having new messages that are generic and fix different use cases at the same time. The idea of using 2 messages is to reduce the size of the message. As per @bmagyar suggestion, I think it is a good idea to go with 2 different publishers, one as a transient_local for names and another for the list of values

Regarding pal_statistics messages, I didn't want to depend on pal_statistics messages per se, as they semantically do not fit the current use case. Moreover, we will have only 1 version and won't be using the version tag

@christophfroehlich
Copy link
Contributor

I thought of having new messages that are generic and fix different use cases at the same time.

Following the strategy of removing generic message types from std_msgs, I'd avoid "generic" messages but be more descriptive here.

The idea of using 2 messages is to reduce the size of the message. As per @bmagyar suggestion, I think it is a good idea to go with 2 different publishers, one as a transient_local for names and another for the list of values

This is fine.

Regarding pal_statistics messages, I didn't want to depend on pal_statistics messages per se, as they semantically do not fit the current use case. Moreover, we will have only 1 version and won't be using the version tag

Ok.

@saikishor
Copy link
Member Author

Following the strategy of removing generic message types from std_msgs, I'd avoid "generic" messages but be more descriptive here.

@christophfroehlich What you say is very valid. I understand it. I was about to make the change and unfortunately found this InterfaceValue.msg this doesn't allow me to rename the message. Any help with alternative naming?

@christophfroehlich
Copy link
Contributor

Maybe InterfaceNames and InterfaceValues? This would be similar to pal_statistics_msgs?
Or InterfacesNames and InterfacesValues?

@saikishor saikishor changed the title Add StringArray and ValuesArray messages Add InterfacesNames and InterfacesValues messages Nov 13, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit, apart from that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants