Skip to content

Add a constant value for failing to set an undeclared parameter #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Draft

Add a constant value for failing to set an undeclared parameter #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e3f5f
Add a constant value for failing to set an undeclared parameter
mxgrey Apr 29, 2024
40d429d
Use lowercase to match other reasons in rclcpp
mxgrey Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rcl_interfaces/msg/SetParametersResult.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ bool successful
# Reason why the setting was a failure. On success, the contents of this field
# are undefined. This should only be used for logging and user interfaces.
string reason

# This reason for failing to set a parameter value should be given when the node
# is only allowed to set values for declared parameters, and the parameter that
# the request was trying to set not declared by the node. Use the ListParameters
# service to see which parameters are declared.
string REASON_UNDECLARED_NOT_ALLOWED = "parameter is not declared by the node, which only allows declared parameters"