Expose Python code generation via rosidl generate CLI #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works to a partial extent. Current generator code assumes the namespace structure in IDL files replicates their typical layout in the filesystem i.e. in a given ROS package within a subdirectory, to the point it uses either interchangeably. If the above convention is not respected, this code generator falls apart. I fear it's not the only code generator doing this. |
21 tasks
hidmic
force-pushed
the
hidmic/rosidl-generate-py
branch
from
b413229 to
74b9d75
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
force-pushed
the
hidmic/rosidl-generate-py
branch
from
74b9d75 to
534167d
Compare
|
Need |
Signed-off-by: Michel Hidalgo <[email protected]>
ahcorde
approved these changes
Mar 10, 2021
|
CI up to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of ros2/rosidl#567. Connected to ros2/rosidl#565.