Skip to content

Conversation

@tqk2811
Copy link

@tqk2811 tqk2811 commented Oct 18, 2025

issues #589

  • Make FFProbeAnalysis and ctor public
  • Remove [JsonIgnore]
    [JsonIgnore] public IReadOnlyList<string> ErrorData { get; set; } = new List<string>();
  • Add FFProbe.GetAnalysis and FFProbe.GetAnalysisAsync
    • Analyse and AnalyseAsync change to use GetAnalysis and GetAnalysisAsync
//Remote
var anl = await FFProbe.GetAnalysisAsync(filePath_or_stream);
response anl as json

//Client
string json = ...;
FFProbeAnalysis anl =  JsonSerializer.Deserialize<FFProbeAnalysis>(json);
return new MediaAnalysis(anl);

@tqk2811 tqk2811 changed the title Remote Analyse #589 Remote Analyse Oct 18, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.67%. Comparing base (1c4333e) to head (89d4235).
⚠️ Report is 161 commits behind head on main.

Files with missing lines Patch % Lines
FFMpegCore/FFProbe/FFProbe.cs 68.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   71.20%   68.67%   -2.53%     
==========================================
  Files         117      122       +5     
  Lines        2973     3496     +523     
  Branches      284      309      +25     
==========================================
+ Hits         2117     2401     +284     
- Misses        751      980     +229     
- Partials      105      115      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tqk2811 tqk2811 changed the title Remote Analyse Support send and received analysis data over I/O Oct 18, 2025
@tqk2811 tqk2811 changed the title Support send and received analysis data over I/O Support send and received analysis data over I/O stream Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants