Skip to content

Feature/configure blob caching #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/configure blob caching #105

wants to merge 5 commits into from

Conversation

hishamanver
Copy link
Contributor

@hishamanver hishamanver commented Aug 4, 2021 •
edited
Loading

This PR implements the following:

What:

  1. Enable configuration of 'proxy_cache_valid' age with CACHE_VALIDITY_PERIOD var (defaults to 60d)
  2. Enable configuration of 'proxy_cache_path' 'inactive' setting with CACHE_MAX_AGE var (defaults to 60d)
  3. Allows serving from STALE cache for non-manifest layers (eg: blob) when upstream is not available (e.g. connectivity issues / airgapped solution)

Why:

  1. We want to be able to pull images and cache them for variable periods of time (e.g. forever).
  2. We want to limit the impact of upstream outages by always allowing serving of STALE content if there are upstream issues

Comments welcome

Happy to update readme post discussion

@hishamanver
Copy link
Contributor Author

includes changes from #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hishamanver