Bug Fix: Fix NOAUTH when using Sentinel with Password #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please fix the test errors so I can merge this in? |
|
I can, but is this the approach you want to take? There are several ways to address this bug, for example you may want another config value for the SENTINEL password instead. Please let me know if this is your preferred approach. |
|
I think it would be better if the user can explicitly specify auth credentials to sentinels. |
Merge from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using Sentinel the password from the config is not passed through to the Sentinel class which results in a NOAUTH when connecting.
This patch passes through the same
PASSWORDfrom the config through to both the Sentinel and the Master. This may not be what you want but it will solve the problem if both passwords are the same.