Add SetupPayload type, and use SetupPayload for getRequestHandler #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linux_china <[email protected]>
Signed-off-by: linux_china <[email protected]>
Signed-off-by: linux_china <[email protected]>
OlegDokuka
approved these changes
Nov 26, 2021
|
@linux-china can you please sign your commits and I will merge the PR Thanks! |
|
@OlegDokuka I used Github Codespaces to modify the code and forgot to sign the comments. commit sign required for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now setupPayload contains data and metadata only, and it should contains keepLive, lifetime, metadataMimeType, dataMimeType attributes. metadataMimeType and dataMimeType is very useful for data encoding/decoding on connection level.