[Fix #49] Add new Rails/RescueFromExceptionsVariableName cop
#1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydakuka
changed the title
Rails/RescueFromExceptionsVariableName copRails/RescueFromExceptionsVariableName cop
ydakuka
force-pushed
the
49-rescued_exception_variable_name
branch
from
b7c698b to
8eaea82
Compare
Ensures that rescued exception variables are named as expected. The `PreferredName` config option specifies the required name of the variable. Its default is `e`, as referenced from `Naming/RescuedExceptionsVariableName`.
ydakuka
force-pushed
the
49-rescued_exception_variable_name
branch
from
8eaea82 to
0363212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Based on #139
Ensures that rescued exception variables are named as expected.
The
PreferredNameconfig option specifies the required name of the variable.Its default is
e, as referenced fromNaming/RescuedExceptionsVariableName.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.