Fix false negative for RSpec/RepeatedExampleGroupDescription cop when include skip/pending
#2120
+203
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn’t find at a glance, why did we implement it in a way that it was skipping pending and skip? |
|
@pirj I think they were more guarded than necessary to prevent false positives below. No other discussion of skip was found in the PR when the cop was created. context 'rejected' do
skip
end
context 'processed' do
skip
endrefs: #860 (review) |
ydah
force-pushed
the
2021
branch
2 times, most recently
from
01f47bd to
489717d
Compare
pirj
reviewed
Oct 6, 2025
| RUBY | ||
| end | ||
|
|
||
| it 'does not register offense for example group with skip' do |
There was a problem hiding this comment.
This description is not exactly fair, is it?
We do not register an offence, but because context descriptions are different. Wouldn’t this pass before the fix, too?
pirj
reviewed
Oct 6, 2025
| RUBY | ||
| end | ||
|
|
||
| it 'does not register offense for example group with pending' do |
…en include skip/pending Fixes: #2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2021
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).