Skip to content

Conversation

@m-nakamura145
Copy link
Contributor

this PR has been changed to use the ruby/actions workflow for ruby versions.

with:
engine: cruby
min_version: 2.5
versions: "[debug]"
Copy link
Contributor

@olleolleolle olleolleolle Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps like this:

Suggested change
versions: "[debug]"
versions:
- debug

...or perhaps it's called head, not debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can't use JSON array here...: https://github.com/ruby/fiddle/actions/runs/7472168103/workflow

The workflow is not valid. .github/workflows/ci.yml (Line: 14, Col: 9): A sequence was not expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fixed 6e2f4b9

@kou
Copy link
Member

kou commented Jan 11, 2024

We may need to add a condition for head to

matrix.ruby == 'debug' ||

BTW, do we need both of head and debug?

@kou
Copy link
Member

kou commented Apr 21, 2025

Could you rebase on master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants