Handle SyntaxError#message with invalid encoding #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related: https://bugs.ruby-lang.org/issues/21528 This patch fixes an issue in IRB where it fails to handle a `SyntaxError#message` that has invalid encoding. The root cause is that prism may generate a `SyntaxError#message` with broken encoding when the source contains multibyte characters. This patch ensures irb can handle such cases gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://bugs.ruby-lang.org/issues/21528
This patch fixes an issue in IRB where it fails to handle a
SyntaxError#messagethat has invalid encoding.The root cause is that prism may generate a
SyntaxError#messagewith broken encoding when the source contains multibyte characters. This patch ensures irb can handle such cases gracefully.However, if this is considered a bug in Ruby itself, this pull request does not need to be merged.