Skip to content

Conversation

AllanSiqueira
Copy link

Issue: #143

  • Add new configuration to preserve headers case in Net::HTTP class
  • Add new configuration to preserve headers case in GenericRequest class

@AllanSiqueira AllanSiqueira force-pushed the preserve-headers-option branch from 844b130 to b828e8f Compare August 16, 2023 12:44
@AllanSiqueira AllanSiqueira marked this pull request as ready for review August 19, 2023 04:58
- Add new configuration to preserve headers case in Net::HTTP class
- Add new configuration to preserve headers case in GenericRequest class
@AllanSiqueira AllanSiqueira force-pushed the preserve-headers-option branch from b828e8f to 7daa433 Compare September 11, 2023 12:34
Copy link
Member

@nobu nobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name doesn’t feel nice to me.
What of headers does it preserve?

@AllanSiqueira
Copy link
Author

The name doesn’t feel nice to me. What of headers does it preserve?

Great, what do you think we call it capitalize_headers, make it default true.

@nobu
Copy link
Member

nobu commented Nov 1, 2023

The name doesn’t feel nice to me. What of headers does it preserve?

Great, what do you think we call it capitalize_headers, make it default true.

It sounds fine.

@AllanSiqueira AllanSiqueira force-pushed the preserve-headers-option branch from 1424174 to d688a13 Compare November 7, 2023 17:25
@AllanSiqueira AllanSiqueira requested a review from nobu November 7, 2023 17:26
@AllanSiqueira
Copy link
Author

Done the changes, when you have the time, may you review it again @nobu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants