Fix the framework helper method in the github advisory sync #958
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the repo's code after a recent contribution (out of curiosity) and I've found one very strange method for the Github Advisory sync process. I wasn't sure what it should do, as it made no sense, it returned
nilregardless of its (implicit) inputs. So I did a bit more investigation and found that it meant to mark some vulnerabilities to be part of a framework, but it was lost over time. The history of the method looks like this:%[]from the case-when conditionsrails) to be part of the condition listNot sure if I need to re-run anything to backfill the framework data or anything like that, but I'm happy to do that if it helps, just let me know.