avm2: Fix Loader.content.loaderInfo and contentLoaderInfo compatibility #21121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
Lord-McSweeney
added
the
waiting-on-review
|
What does this PR do? It's not described, neither in the PR nor in the comments. How does this relate to the comment in the code that objects return loaders from the avm root? In order to get a PR merged you need to convince people that's the right patch, but there are no tests and no description, so you're leaving all this work (which is a significant part of landing a patch) on maintainers/reviewers. That's why there hasn't been a review for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't probably the most elegant way to go about it, but it fixes the powerbook swf from discord.