avm1: Fix signed zero behavior in Math.min/max
#21223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flash Player normalizes signed zeros returned by Math.min/max to +0.
This test verifies the behavior of comparing zeros in Math.min/max.
kjarosh
added
A-avm1
|
See issue #8336. I'm pretty sure AVM1 normalizes all signed zeros to +0, in all circumstances (maybe as part of automatic float-to-int conversions?), so maybe we should add this check in the |
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash Player normalizes signed zeros returned by
Math.min/maxto +0.