avm2: Only call init methods when necessary #21271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
Lord-McSweeney
commented
Aug 9, 2025
Lord-McSweeney
force-pushed
the
avm2-no-init
branch
from
63c75ca to
9078d76
Compare
Lord-McSweeney
added
the
waiting-on-review
Lord-McSweeney
force-pushed
the
avm2-no-init
branch
from
9078d76 to
941bb4d
Compare
Lord-McSweeney
force-pushed
the
avm2-no-init
branch
from
941bb4d to
ace59ff
Compare
…ime` Calling the init method would ensure that the created Date object would always have the current date and time set, which was unintended
This affects Context3DObject, IndexBuffer3DObject, Program3DObject, TextureObject, and VertexBuffer3DObject
This requires also storing the default object encoding on Avm2 so we can access it without an Activation
This allows us to remove StageObject::for_display_object_childless_with_args
It now takes an UpdateContext rather than an Activation and returns a non-Result
The MorphShape class is final, and its init method is a no-op
The StaticText class is final, and its init method is a no-op
Lord-McSweeney
force-pushed
the
avm2-no-init
branch
from
ace59ff to
05dd423
Compare
Lord-McSweeney
removed
the
waiting-on-review
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Aug 29, 2025
---------------------------------------------------------------------------------- clk.mk eeb06de916c23e48d425a6a772aebf897e94bae9 # Version: Commits on Aug 27, 2025 ---------------------------------------------------------------------------------- Merge pull request #1540 from TomHarte/KeyboardAgain Be more rigorous about `static constexpr`, ------------------------------------------------------------------------------------- hatari.mk 39b5854b31e4c103360e193b1cbddb21d7d46842 # Version: Commits on Aug 26, 2025 ------------------------------------------------------------------------------------- Increase max 8-bit VDI mode resolution to 800x600 as there's program that actually requires that large resolution. And move games working with 8-bit (VDI) mode on TT, from Falcon to TT section in the compatibility docs., --------------------------------------------------------------- ruffle.mk nightly-2025-08-27 # Version: Commits on Aug 27, 2025 --------------------------------------------------------------- ## What's Changed * chore: Update translations by @RuffleBuild in ruffle-rs/ruffle#21461 * build(deps-dev): bump the npm-minor group in /web with 18 updates by @dependabot[bot] in ruffle-rs/ruffle#21476 * build(deps): bump the cargo-minor group with 11 updates by @dependabot[bot] in ruffle-rs/ruffle#21478 * avm2: Only call init methods when necessary by @Lord-McSweeney in ruffle-rs/ruffle#21271 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-08-26...nightly-2025-08-27, ----------------------------------------------------------------------------------- ymir.mk e3d071f80126c03a1106e50e4ae21bd437a9e902 # Version: Commits on Aug 27, 2025 ----------------------------------------------------------------------------------- fix(input): Clear gamepad 1D axis values in `ResetGamepadInputs`, ---------------------------------------------------------------------------------------- rpi-utils.mk 49621512ec33a52432aa826441f058ba8da2c3af # Version: Commits on Aug 26, 2025 ---------------------------------------------------------------------------------------- rpifwcrypto: armhf printf fixes, ---------------------------------------------------------------------------------------- retroarch.mk aa1988088cc01997cf4e56995219bee13cba63df # Version: Commits on Aug 27, 2025 ---------------------------------------------------------------------------------------- Non-unified dupe key event fix,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #20892
This uncovered a bug where
DateObject::from_date_and_timewas always returning a Date with the current date.