core: Store PreloadProgress.next_preload_chunk as an Option<u64>
#21755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using `u64::MAX` as a sentinel value
Lord-McSweeney
added
A-core
n0samu
approved these changes
Sep 23, 2025
Lord-McSweeney
added
the
waiting-on-review
|
I'm not sure if I entirely agree - Option<u64> is larger than a regular u64, and I don't think there's anything wrong with using u64::MAX as a sentinel value. Is there any other reason for this other than for style? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using
u64::MAXas a sentinel value