core/avm1: Execute DoInitActions in movies loaded through ImportAssets with the proper context.
#21944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
force-pushed
the
import-assets-do-init-action
branch
from
82f0840 to
343fc78
Compare
moulins
added
A-avm1
moulins
force-pushed
the
import-assets-do-init-action
branch
from
343fc78 to
de23bae
Compare
|
Does not fix gnash tests :( |
| # Tests DoInitAction behavior in child movies, both when | ||
| # loaded through a `MovieClipLoader` and through `ImportAssets2`. | ||
| # | ||
| # .swf files where handcrafted using the JPEXS Decompiler and have |
There was a problem hiding this comment.
typo: where -> were
Lord-McSweeney
approved these changes
Oct 17, 2025
…SwfMovie>`. This will be needed for executing `DoInitAction` blocks in movies loaded through `ImportAssets` in the correct context.
Dinnerbone
force-pushed
the
import-assets-do-init-action
branch
from
de23bae to
d173961
Compare
It does, yes. |
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21703.
Supersedes #21725, with a more correct approach.
Movies loaded through
ImportAssets(2)should not be accessible via AVM1 bytecode (in particular, they don't have an associatedAVM1Object); this is enforced by executing anyDoInitActionblock encountered during preload as if it was in the parent importer movie.