fix: api 500er with policy, check getCommands index against commentCommand lenght #5618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochen
force-pushed
the
try-fix-api-500-with-policies
branch
from
5f55833 to
d1fc0a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
If the api is called for plan and policies are activated, the commentCommand is shorter than the count of cmds. This leads to a 500.
The check prevents a crash here and a warning is issued.
I could not find out why there is a discrepancy here.
why
First of all to prevent the crash and thus prevent the 500. The warning can then help to recognize the cases when both counts deviate from each other.
tests
Tests were carried out manually, after the change there were no more api/plan 500s with activated policies.
references
It may alsocloses a GitHub issue
#4318, but you cannot see whether policies are active.