Hotfix resolve index projection for references/pointers #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
commented
Aug 1, 2025
| } | ||
|
|
||
| fn g(x: *const u32) { | ||
| // assert!(unsafe{*x} == 0); // deref alignment check currently failing |
There was a problem hiding this comment.
This line creates code for the pointer alignment check which currently creates thunks and gets stuck.
The alignment check (as well as the unOpOffset) require simulating an address according to the referenced type, its (original) size and alignment must be respected on offsets and when transmuteing pointers to numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The projections stored within a reference or pointer may include
Index(L:Local), indexing with an index read from a local.When creating a reference or pointer, the context is lost, so the actual index must be read from the local and stored as a
ConstantIndexprojection.Also adding a test for a previous change (offset correction when passing structs holding references across stack frame boundaries)