Use $CARGO_BUILD_TARGET_DIR to determine where output should go #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical target location is `target/`, but that can be customized (e.g. in workspace builds), so construct the correct path name for the output files. This also uses PathBuf construction functions instead of the slightly more error-prone format! statements to construct those pathnames.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adjusts the file-name creation routines (which make all the target/machine paths) to take CARGO_BUILD_TARGET_DIR into account, which should enable workspace builds as in #19.
It also adjusts the way filename handling is done to use
PathBuf, and switches tocreate_dir_all(which should ensure subdirectories, if they ever get added, get created correctly).Testing /:
I couldn't formulate a reasonable test for this - all the tools I tried (
trybuildmainly) reset the cargo env variables, which makes it impossible to adjust that. But I tried the build in a workspace crate by pulling in the patched version ofmachineby path... and that worked.)