Fix lints and remove doc_auto_cfg
#191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems this has been removed and recent nightly compiler won't build this crate as is. Some random post says use `doc_cfg` instead but we have that already so just remove the `doc_auto_cfg`. I didn't think too hard about this. ref: https://users.rust-lang.org/t/fallout-from-removal-of-doc-auto-cfg/134435
Member
Author
|
There has been a bit of work here, instead of backporting this to 0.3.0 shall we just cut a 0.4.0 @apoelstra? |
This macro is only used in the file it is defined, remove the unnecessary re-export. Found by recent nightly `clippy`.
tcharding
force-pushed
the
push-wuqwplkvmwlz
branch
from
9a70755 to
a43841f
Compare
Recent clippy is erroring with: error: unexpected `cfg` condition name: `rust_version` Config clippy in the manifest as is customary.
Update nightly to verify that it builds now that `doc_auto_cfg` has been removed.
tcharding
force-pushed
the
push-wuqwplkvmwlz
branch
from
a43841f to
b79a0e1
Compare
Member
|
We probably have to backport the |
Member
Author
|
Ah true that, I'll do a backport then we can release either or both? |
Member
Author
|
Shall we give this a few days and see what happens in the community first? |
Member
|
Nah, let's just work on backporting. But we don't need to be too urgent about it. |
Member
|
@tcharding can we get a 0.3.1 out with this pls? |
Member
Author
|
Done in #194, the lint patch didn't apply. Lets see what CI says. EDIT: For clarity, backport done in 194 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-bitcoinis failing to lint and docs build with a recent nightly toolchain because of this crate.Fix both issues then update nightly to prove its ok.