Skip to content

Conversation

@ml0mbardi
Copy link
Contributor

@ml0mbardi ml0mbardi commented Nov 15, 2025

Fixes three typos found in the codebase:

  • constuctconstruct (src/descriptor/mod.rs:159)
  • satisifiedsatisfied (src/miniscript/context.rs:786)

@apoelstra
Copy link
Member

Wiktionary claims that both "parseable" and "parsable" are correct, and "parseable" appears in many other parts of this library, including trait names that cannot be changed in a non-breaking way.

@ml0mbardi ml0mbardi changed the title Fix typos in comments and messages Fix typos in comments Nov 20, 2025
@ml0mbardi
Copy link
Contributor Author

Wiktionary claims that both "parseable" and "parsable" are correct, and "parseable" appears in many other parts of this library, including trait names that cannot be changed in a non-breaking way.
@apoelstra Hi ,
Good point, reverted. Thanks for catching that.

@apoelstra
Copy link
Member

Great, thanks! And thanks for having concise but clear commit and PR descriptions.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cc0b834; successfully ran local tests

@apoelstra apoelstra merged commit 5deec51 into rust-bitcoin:master Nov 21, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants