-
Notifications
You must be signed in to change notification settings - Fork 32
Suggested edits to the interrupts chapter #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tomer-Eliahu
wants to merge
7
commits into
rust-embedded:main
Choose a base branch
from
Tomer-Eliahu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5bc7aa3
make the challenge prompt match challenge code and fix typos
Tomer-Eliahu 777bc16
add comment about critical section and higher priority interrupts int…
Tomer-Eliahu 11df833
add proc macro comment + fix typo
Tomer-Eliahu 70663a4
Clarified what marking a function with the interrupt attribute does
Tomer-Eliahu ad64d0c
Improve wording
Tomer-Eliahu cb65c3f
Merge branch 'rust-embedded:main' into main
Tomer-Eliahu 3b7d4d4
Link to Macros chapter and reword macro paragraph
Tomer-Eliahu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should explain further about proc macros here; it's a complicated concept in its own right. Maybe link to the Book of Macros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I think maybe link to the Macros section in the Rust Book (which then itself links to the Book of Macros)?
From skimming these just now, while the Book of Macros mentions ways to expand macros (like the Playground option), they don't mention the rust-analyzer command.
I think maybe it is worth mentioning briefly how to expand macros, so that someone reading this can get a quick understanding of roughly what the interrupts macro does without having to learn Macro syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited that bit now, what do you think?