add tracing #551
Draft
add tracing #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
currently looks like this
|
|
What is default log level? |
|
Default log level is set on Line 204 in 0db4838 |
|
Any progress on this? |
Emilgardis
commented
Nov 13, 2021
| .without_time() | ||
| .with_target(false) | ||
| .with_env_filter(filter) | ||
| .compact() |
There was a problem hiding this comment.
with compact
with full
I prefer compact, looks cleaner imo
There was a problem hiding this comment.
I'd want to remove the render:expand:etcetc things, but that would require a custom formatter, simple to do but maybe not neccessary, this shouldn't be used often
|
@Emilgardis should I make new release or wait for this PR? |
|
Go ahead with a release, this is breaking but can be made to not be :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some changes to how logging is done and displayed.
More work maybe needed.
Depends on rust-embedded/svd#172