add windows signal handlers to server executable #11745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Aug 23, 2025
Comment on lines
+155
to
+161
| tokio::select! { | ||
| _ = ctrl_break => {}, | ||
| _ = ctrl_c => {}, | ||
| _ = ctrl_close => {}, | ||
| _ = ctrl_logoff => {}, | ||
| _ = ctrl_shutdown => {}, | ||
| } |
There was a problem hiding this comment.
do we need all of them? if this is just for local development, shouldn't e.g. ctrl_c be sufficient? 🤔
There was a problem hiding this comment.
I don't know, I just figured I'd use them all while they're not placed.
To be fair I didn't find the recommended semantics for the signals to be particularly well-documented
There was a problem hiding this comment.
since I don't have a Windows machine here, can you check if the following is sufficient and compiles?
#[cfg(windows)]
async fn shutdown_signal() {
ctrl_c()
.expect("failed to install signal handler")
.recv()
.await
}it's a bit unfortunate that CI won't be able to check that this actually compiles since we run CI only on Unix, but I don't think it makes sense for us to run CI on Windows too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am aware that windows isn't supposed to supported officially, but this would at least help the server executable compile on windows.
I hope it's not too inconvenient if I go through some of the hiccups a windows user might have when trying to get this running on their platform