Fix running inside miri when using in-process accounting #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipe2 was introduced in Linux 2.6.27 while our minimum is 3.2. And Glibc 2.9 while we need 2.17.
Miri doesn't support the raw syscall variant.
Miri doesn't support signals and the cleanup is best-effort anyway.
weihanglo
approved these changes
Aug 22, 2025
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
This seems reasonable. Thanks.
A bit more history:
pipe2() was added in kernel 2.6.27 and glibc 2.9. 1
Since Rust 1.64.0 (2022-09-22) 2, we requires
- glibc >= 2.17 (previously glibc >= 2.11)
- kernel >= 3.2 (previously kernel >= 2.6.32)
The oldest version requiring glibc-2.11 / kernel-2.6.32 I can found from doc 3 is 1.47.0 (2020-10-08). However, our MSRV is already [1.63 one year ago 4. If people using toolchain older than 1.47, their build are already broken.
Anyway, it is reasonable. Thanks!
Footnotes
Member
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miri doesn't currently support mkfifo, so can't present named pipes for other processes (but spawning processes isn't possible from miri anyway) And it also isn't possible in miri to get fd's inherited from the parent process. But this is enough for what running rustc in miri needs.
Fixes #108