Promote ctest-next to ctest
#4655
Conversation
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
68558dc to
b316b10
Compare
.github/workflows/ci.yaml
Outdated
| - name: Remove edition 2024 crates | ||
| run: perl -i -ne 'print unless /"ctest-(next|test)",/ || /"libc-test",/' Cargo.toml | ||
| run: perl -i -ne 'print unless /"ctest(?:-test)?",/ || /"libc-test",/' Cargo.toml |
There was a problem hiding this comment.
Delete this bit now since the ctest-next msrv is the ctest msrv.
While you're here, could you rename this job from "Check MSRV" to "Check ctest MSRV"?
There was a problem hiding this comment.
The version of cargo the CI uses doesn't seem to support 2024 edition. EDIT: It seems that the command used for MSRV picks up the old ctest and not the new one since they have the same name.
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
b316b10 to
1637b76
Compare
mbyx
force-pushed
the
libc-promote-ctest-next
branch
3 times, most recently
from
be84053 to
28bf588
Compare
.github/workflows/ci.yaml
Outdated
| msrv="$(cargo metadata --format-version 1 | jq -r --arg CRATE_NAME ctest '.packages | map(select(.name == $CRATE_NAME)) | first | .rust_version')" | ||
| msrv="$(cargo metadata --format-version 1 | jq -r --arg CRATE_NAME ctest '.packages | map(select(.name == $CRATE_NAME)) | last | .rust_version')" |
There was a problem hiding this comment.
The ordering of the packages isn't guaranteed, so this may not always work. You can grab only the local crate by changing the map(select(...)) query to add and (.id | startswith("path+file"))
If you could rewrap this a bit too that would be good, the line is pretty long already. (Bash should let you split lines anywhere within the $(...))
mbyx
force-pushed
the
libc-promote-ctest-next
branch
from
28bf588 to
c59da70
Compare
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/rust-lang/libc" | ||
| rust-version = "1.63.0" | ||
| publish = false |
There was a problem hiding this comment.
Ah autopublish failed, could you put up a PR to set this true? I'll get it later today if you're not active right now
Description
Promotes
ctest-nextto be the newctest. Platforms not yet ported use the older version ofctestfrom crates.io asctest-old. Testing forctest-oldhas been removed fromctest-test.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI