Add support for tid argument in sched_(get/set)affinity #4130
Conversation
| // TODO: when https://github.com/rust-lang/miri/issues/3730 is fixed this should use its notion of tid/pid | ||
| let thread_id = match pid { | ||
| 0 => this.active_thread(), | ||
| let thread_id = match (pid, &*this.tcx.sess.target.os) { |
There was a problem hiding this comment.
Seems a bit odd to match on the pair here. I think this is more clear as
if pid == 0 { ... }
else if this.tcx.sess.target.os == "linux" {
// On Linux we support `gettid`, which is guaranteed to support IDs matching `sched_getaffinity`.
...
} else { ... }
| let thread_id = match (pid, &*this.tcx.sess.target.os) { | ||
| (0, _) => this.active_thread(), | ||
| (tid, "linux") => { | ||
| if let Ok(tid) = this.machine.threads.thread_id_try_from(tid) { |
There was a problem hiding this comment.
This will not return the right ID. See the gettid implementation to see how ThreadId is converted to the user-visible TID; this here will have to do the opposite transformation. Please put both directions in some shared place to make sure they remain consistent in the future.
RalfJung
left a comment
RalfJung
left a comment
There was a problem hiding this comment.
Thanks for the PR! However, as-is this doesn't quite have the right behavior.
Please also add a test ensuring we can set an affinity via the TID and then get it via "0" and vice versa.
|
☔ The latest upstream changes (possibly 1c87fa0) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
the
S-waiting-on-author
|
I'm going to close this PR due to inactivity. Thanks for trying to contribute, and feel free to reopen or make a new PR if you want to get back it it again! |
rustbot
removed
the
S-waiting-on-author
3 participants
Linked to #4062
On Linux, values returned by
gettidcan be passed as thepidargument when callingsched_getaffinityorsched_setaffinity.