Add support for building and linking against genmc #4498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to Miri! |
|
LGTM, we just need to make sure to add the platform checks once the actual functionality is added. |
|
Which platform checks? |
Patrick-6
reviewed
Jul 27, 2025
Comment on lines
22
to
31
| if !cfg!(all( | ||
| feature = "genmc", | ||
| any(target_os = "linux", target_os = "macos"), | ||
| target_pointer_width = "64", | ||
| target_endian = "little" | ||
| )) { | ||
| unimplemented!( | ||
| "GenMC mode is not supported on this platform, cannot handle argument: \"-Zmiri-genmc{trimmed_arg}\"" | ||
| ); | ||
| } |
There was a problem hiding this comment.
These checks. Maybe we could put them here in miri.rs?
There was a problem hiding this comment.
Ah, no, the dummy version will be used on unsupported platforms, it is ok then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4453 with some minor changes from my side.